Miscellaneous commits in preparation for background indexing #1214
Conversation
|
@swift-ci Please test |
ahoppen
force-pushed
the
background-index-preparation
branch
from
9bdc440 to
4791ea7
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
background-index-preparation
branch
from
4791ea7 to
f27e4b4
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
background-index-preparation
branch
from
f27e4b4 to
c18634a
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
background-index-preparation
branch
from
c18634a to
1a64da0
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
| @@ -20,6 +20,8 @@ public enum TaskDependencyAction<TaskDescription: TaskDescriptionProtocol> { | |||
| case cancelAndRescheduleDependency(TaskDescription) | |||
| } | |||
|
|
|||
| private let taskSchedulerSubsystem = "org.swift.sourcekit-lsp.task-scheduler" | |||
There was a problem hiding this comment.
Couldn't we just have a separate logger?
There was a problem hiding this comment.
I just preferred to stick to the withLoggingSubsystem, which we’ll also use for indexing (indexing will be in a different subsystem) instead of having two different notions of how to create loggers for subsystems.
And logging needs to store the subsystem in a task local variable because otherwise all log messages from SwiftPMBuildSystem that were called from the indexer would end up in the org.swift.sourcekit-lsp subsystem instead of org.swift.sourcekit-lsp.indexing.
No particular motivation for this change.
This way we’ll be able to use it from the semantic indexer.
This will allow us to conditionally enable background indexing in tests
This allows us to enable background indexing for a workspace based on a value in `SourceKitLSPServer.Options`.
…erver` to `BuildSystemManager` This allows us to determine the toolchain to use during background indexing. It also moves toolchain selection closer to the build system, which is good because when we support multiple toolchains for a single workspace, the build system is what decides which toolchain to use for which document.
The build system has potentially more information about a document's language than we do based on the file’s extension.
… the process if the `Task` is cancelled
This allows us to get rid of the lock.
ahoppen
force-pushed
the
background-index-preparation
branch
from
1a64da0 to
28d0dd3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
A collection of unrelated commits that background indexing and preparation will build upon (and a few unrelated cleanup commits).
Best reviewed commit by commit.