Support background preparation of targets #1273
Conversation
|
@swift-ci Please test |
ahoppen
force-pushed
the
background-preparation
branch
from
64865b8 to
7d8e10c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
| try self.workspace.resolve( | ||
| root: PackageGraphRootInput(packages: [AbsolutePath(projectRoot)]), | ||
| observabilityScope: observabilitySystem.topScope | ||
| ) | ||
| try await self.reloadPackage() |
There was a problem hiding this comment.
It looks like reloadPackage calls loadPackageGraph, which calls into _resolve, is our call to resolve necessary?
There was a problem hiding this comment.
There is a subtle difference here that we don’t set forceResolvedVersions: true here. This ensures that we generate a Package.resolved if none exists. I think we need to do some more design work here about when we should do it. I’ll file an issue for it and do it in a follow-up PR.
There was a problem hiding this comment.
OK, I had to set forceResolvedVersions: false during an index build anyway. 5e83d7d
…ld directory When `SwiftPMBuildSystem` operates on a ` .index-build` directory, it owns the checkouts and is thus also allowed to resolve the package versions. This is necessary
ahoppen
force-pushed
the
background-preparation
branch
from
7d8e10c to
740262c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
No description provided.