Don’t show a “Preparing current file” progress while determining target of file #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et of file Every time a request regarding a text document is sent, we call `schedulePreparationForEditorFunctionality` on the `SemanticIndexManager` with the assumption that it’s a no-op if the target is already prepared. We did, however, show the “Preparing current file” status while we were determining the file‘s target to determine that the file’s target is up-to-date.
|
@swift-ci Please test |
bnbarham
approved these changes
May 31, 2024
Comment on lines
+881
to
+882
| // Opening the document prepares it for editor functionality. Its target is already prepared, so we shouldn't show | ||
| // a work done progress for it. |
There was a problem hiding this comment.
What make sit already prepared?
There was a problem hiding this comment.
Creating a SwiftPMTestProject polls the index (pollIndex parameter in the initializer defaults to true), so just creating the project will ensure that the index is up-to-date.
hamishknight
reviewed
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a request regarding a text document is sent, we call
schedulePreparationForEditorFunctionalityon theSemanticIndexManagerwith the assumption that it’s a no-op if the target is already prepared. We did, however, show the “Preparing current file” status while we were determining the file‘s target to determine that the file’s target is up-to-date.