Skip to content

Don’t run a swift build command to prepare a package manifest #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 31, 2024

Package manifests don’t have an associated target to prepare and are represented by a ConfiguredTarget with an empty target ID. We were mistakingly running swift build with an empty target name to prepare them, which failed. There is nothing to prepare.

@ahoppen ahoppen requested review from bnbarham and hamishknight May 31, 2024 14:39
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 31, 2024 14:39
@ahoppen
Copy link
Member Author

ahoppen commented May 31, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the dont-prepare-pacakge-manifest branch from 70f48e3 to 9de6755 Compare May 31, 2024 22:56
@ahoppen
Copy link
Member Author

ahoppen commented May 31, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 31, 2024

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the dont-prepare-pacakge-manifest branch from 9de6755 to d589969 Compare June 1, 2024 01:03
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2024

@swift-ci Please test Windows

Package manifests don’t have an associated target to prepare and are represented by a `ConfiguredTarget` with an empty target ID. We were mistakingly running `swift build` with an empty target name to prepare them, which failed. There is nothing to prepare.
@ahoppen ahoppen force-pushed the dont-prepare-pacakge-manifest branch from d589969 to e56c71f Compare June 1, 2024 04:47
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit d8f988b into swiftlang:main Jun 1, 2024
3 checks passed
@ahoppen ahoppen deleted the dont-prepare-pacakge-manifest branch June 1, 2024 22:04
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants