Share module cache between test projects #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
bnbarham
reviewed
Jun 3, 2024
| destination: \(String(describing: self.destinationBuildParameters.configuration)) | ||
| """ | ||
| ) | ||
| logger.fault("Preparation is assuming that tools and destination to have the same build flags") |
There was a problem hiding this comment.
Duplicate, but also this is going to be fairly spammy.
There was a problem hiding this comment.
I don’t expect this ever to be logged because we set the same build flags for the tools and destination build parameters here: https://github.com/apple/sourcekit-lsp/blob/b9c74387f297147d82716195974306384ca59c11/Sources/SKSwiftPMWorkspace/SwiftPMBuildSystem.swift#L245-L259
The intention of the log is that if that assumption is broken in the future, we’ll have a log message that’s pointing us to it.
This improves serial test execution time of eg. `DocumentTestDiscoveryTests` from 36s to 22s because we don’t need to re-build the XCTest module from its interface when using an open source toolchain. This also uncovered that we weren‘t passing the build setup flags to the prepare command. rdar://126493151
ahoppen
force-pushed
the
share-test-module-cache
branch
from
c92a045 to
259d49e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Jun 3, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves serial test execution time of eg.
DocumentTestDiscoveryTestsfrom 36s to 22s because we don’t need to re-build the XCTest module from its interface when using an open source toolchain.This also uncovered that we weren‘t passing the build setup flags to the prepare command.
rdar://126493151