Prepend module name to TestItem IDs #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to have two identically named suites in two different test targets. These were being erroniously rolled up in to the same parent TestItem. Disambiguate these TestItems by prepending the module name. This has the added benefit of making the TestItem IDs a fully qualified name that can be passed to `swift test`. The module name is pulled from the compiler arguments for the target. If no module name can be found we fall back to the `targetID` for the `ConfiguredTarget`.
plemarquand
commented
Jun 27, 2024
Parse the obj-c module name for targets by looking at the `-fmodule-name` flag.
plemarquand
commented
Jun 28, 2024
| extension Array { | ||
| /// Returns the element at the specified index if it is within the Array's | ||
| /// bounds, otherwise `nil`. | ||
| public subscript(safe index: Index) -> Element? { |
There was a problem hiding this comment.
This extension has been useful on previous projects; let me know if its overkill for this one usage and I'll switch to checking the index bounds in place.
There was a problem hiding this comment.
Seems reasonable. Could you also add this file to CMakeLists.txt?
ahoppen
reviewed
Jun 28, 2024
| extension Array { | ||
| /// Returns the element at the specified index if it is within the Array's | ||
| /// bounds, otherwise `nil`. | ||
| public subscript(safe index: Index) -> Element? { |
There was a problem hiding this comment.
Seems reasonable. Could you also add this file to CMakeLists.txt?
ahoppen
approved these changes
Jun 28, 2024
|
@swift-ci Please test |
|
@plemarquand Could you also create a cherry-pick PR for this change to |
auto-merge was automatically disabled
June 28, 2024 18:42
Head branch was pushed to by a user without write access
plemarquand
commented
Jun 28, 2024
ahoppen
approved these changes
Jul 1, 2024
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have two identically named suites in two different test targets. These were being erroniously rolled up in to the same parent TestItem.
Disambiguate these TestItems by prepending the module name. This has the added benefit of making the TestItem IDs a fully qualified name that can be passed to
swift test.The module name is pulled from the compiler arguments for the target. If no module name can be found we fall back to the
targetIDfor theConfiguredTarget.