Add a SourceKit plugin to handle code completion requests #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a sourcekitd plugin that drives the code completion requests. It also includes a `CompletionScoring` module that’s used to rank code completion results based on their contextual match, allowing us to show more relevant code completion results at the top.
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
4925f86 to
c421c32
Compare
This is not available on non-Darwin platforms.
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
4 times, most recently
from
634370c to
66ce780
Compare
Otherwise, we were trying to load sourcekitd without the plugins for the normal SourceKIt-LSP tests and with the plugins for the plugin tests.
On Ubuntu 20.04, you need to define `_GNU_SOURCE` before importing `<string.h>` to get `memmem`. It is thus not available when importing `Glibc`.
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
66ce780 to
52e0351
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
eaf8f7d to
16f897a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
add-sourcekit-plugin
branch
from
1d8c353 to
58f7766
Compare
|
@swift-ci Please test |
rintaro
approved these changes
Jan 14, 2025
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-installer-scripts
that referenced
this pull request
Jan 20, 2025
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains.
ahoppen
added a commit
to ahoppen/swift-installer-scripts
that referenced
this pull request
Jan 20, 2025
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains. rdar://142909870
ahoppen
added a commit
to ahoppen/swift-installer-scripts
that referenced
this pull request
Jan 21, 2025
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains. rdar://142909870
ahoppen
added a commit
to ahoppen/swift-installer-scripts
that referenced
this pull request
Jan 22, 2025
Install the SourceKit plugin, added by swiftlang/sourcekit-lsp#1906 into the Windows toolchains. rdar://142909870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#78421.
This adds a sourcekitd plugin that drives the code completion requests. It also includes a
CompletionScoringmodule that’s used to rank code completion results based on their contextual match, allowing us to show more relevant code completion results at the top.