[build-script] Remove hard-coded install prefix of /usr and pass it in instead #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#30565 |
|
I think you'll need to test with both the main build-script pull and the indexstore-db pull? Looks like this is the one repo that checked both appending |
|
swiftlang/indexstore-db#75 |
benlangmuir
approved these changes
Mar 24, 2020
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a bug upstream in the main build-script, the install prefix set by the user wasn't being passed in to this repo on non-Darwin platforms and these files assumed it to be
/usr. This pull removes that assumption and has the main build-script pass an install prefix appended to the toolchain path instead, swiftlang/swift#30565.Let me know if this will require changing the name of
SOURCEKIT_TOOLCHAIN_PATH.