Add refactoring action to convert stored to computed properties - #2622
Conversation
| WorkspaceEdit( | ||
| changes: [ | ||
| uri: [ | ||
| TextEdit(range: positions["1️⃣"]..<positions["3️⃣"], newText: "\n var x :Int{ 25 }") |
There was a problem hiding this comment.
@Padmashree06: It looks like the refactoring action in swift-syntax doesn’t produce correct whitespaces here (it should be x: Int, not x :Int). Would you be able to work on a fix for that in swift-syntax?
There was a problem hiding this comment.
Yes sure! I will fix it!
There was a problem hiding this comment.
@ahoppen I have fixed the whitespace error in swift-syntax.
|
@swift-ci Please test |
e6c900e to
81df70d
Compare
|
Finally got back to this and updated it to have two distinct code action + resolve phases. Ready for another review. |
|
swiftlang/swift-tools-protocols#72 @swift-ci Please test |
81df70d to
46ca133
Compare
This is the first syntactic refactoring action that needs to perform a cursor info request on `codeAction/resolve`, so the majority of this PR is to add infrastructure for that. Based on swiftlang#2496. Co-Authored-By: Padmashree S S <padmashreess2006@gmail.com>
46ca133 to
a3f9b80
Compare
|
@swift-ci Please test |
659c4b3 to
30bea88
Compare
|
swiftlang/swift-tools-protocols#72 @swift-ci Please test |
|
swiftlang/swift-tools-protocols#72 |
|
swiftlang/swift-tools-protocols#72 |
3 participants
This is the first syntactic refactoring action that needs to perform a cursor info request on
codeAction/resolve, so the majority of this PR is to add infrastructure for that.Based on #2496.