Repository navigation
Conversation
These flags are applied to the entire package, so hoist to the top level.
Add the missing module to enable coverage; remove the conditional wrapping here as both SPM and CMake now enable the DocC integration.
compnerd
marked this pull request as ready for review
September 24, 2026 15:34
compnerd
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
September 24, 2026 15:34
rintaro
approved these changes
Oct 5, 2026
rintaro
left a comment
Member
There was a problem hiding this comment.
This looks good to me, thanks!
Member
Author
|
@swift-ci please test |
Member
Author
|
Bleh, this won't build, its missing one change to build.ps1 (to pass the path). I'll upload that in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build configuration for SourceKit-LSP to add support for a new
DocumentationLanguageServiceand modernizes the CMake setup. The most important changes include introducing a new documentation service library, updating Swift language and CMake requirements, and cleaning up how language services are registered.Build system modernization:
CMakeLists.txtto require CMake 3.29, set Swift language version to 6, and add new Swift compiler options for upcoming features. Also, copyright and license headers were added.RESILIENT_LIBRARIESdefinition fromSources/CMakeLists.txtto the top-levelCMakeLists.txtfor centralization and clarity. [1] [2]Documentation language service integration:
DocumentationLanguageServicestatic library with its own CMake configuration, including all necessary source files and dependencies such asSwiftDocCandDocCCommon.DocumentationLanguageServiceas a dependency ofInProcessClientand as a statically known service for Markdown, tutorial, and Swift file types, removing the previous conditional import logic. [1] [2]Dependency updates:
find_package(SwiftDocC CONFIG REQUIRED)to ensure the documentation compiler is available during build.