Repository navigation
Support package manifest feature completion and diagnostics - #2789
Open
somiljain2006 wants to merge 2 commits into
Open
somiljain2006 wants to merge 2 commits into
somiljain2006 wants to merge 2 commits into
Conversation
somiljain2006
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
October 5, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2774
Implemented SourceKit-LSP support for autocompletion and diagnostics of upcoming and experimental Swift features used in
Package.swift. The change reads supported features directly from the active toolchain usingswiftc -print-supported-features, caches the result per toolchain, and reports diagnostics for unknown features, likely typos, features enabled through the wrong API, and upcoming features that are already enabled by the selected Swift language version. It also provides context-aware completion forenableUpcomingFeatureandenableExperimentalFeature, including support for versioned package manifests, while preserving the correct string replacement range. Added parsing and toolchain caching tests along with comprehensive manifest diagnostics and completion tests covering valid features, typo suggestions, wrong feature categories, already-enabled features, unrelated source files, versioned manifests, and completion text edits.