Uppercase first letter of diagnostics

[ahoppen]

sourcekitd returns diagnostics with the first letter lowercase. Xcode, for example, shows the messages with the first letter uppercases. I think that looks nicer and we should also uppercase the first letter in sourcekit-lsp.

CC @tristanlabelle I noticed this in swiftlang/swift#67510. While it doesn’t change the messages to be imperative, having them start with an uppercase letter maybe makes them stick out a little less.

[ahoppen]

@swift-ci Please test

[benlangmuir]

My concern here is that the first word in the diagnostic might be a keyword or identifier that shouldn't be modified. If this is preferred style, why not update the compiler diagnostics themselves?

[ahoppen]

@swift-ci Please test

[ahoppen]

I think on the command line we want to emit diagnostics that start with a lowercase letter to match clang. But in IDEs the errors show up more nicely if they start with an uppercase letter.

If the diagnostic starts with an identifier or keyword, that identifier/keyword should be wrapped in single quotes, which means that the quote would be the first character, so we wouldn’t uppercase the identifier or keyword.

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

@swift-ci Please test Windows

[bnbarham]

I think on the command line we want to emit diagnostics that start with a lowercase letter to match clang. But in IDEs the errors show up more nicely if they start with an uppercase letter.

Do you know if this is actually true? Might be worth bringing up the conversation. FWIW someone actually did the imperative switch: swiftlang/swift#67909 :)

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows