Implement push diagnostics in terms of DocumentDiagnosticsRequest
#902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/unify-diagnostics
branch
2 times, most recently
from
fd6dcbb to
47a6f5a
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 17, 2023
hamishknight
approved these changes
Oct 17, 2023
Instead of listening for document updates sent from `sourcekitd` and sending a `PublishDiagnosticsNotification` based on the `sourcekitd` notification, wait for a little while and then execute an internal `DocumentDiagnosticsRequest` to load diagnostics and send them to the client. This has two advantages: - It unifies the two diagnostic implementations - It removes the need to keep track of semantic diagnostics in `SwiftLanguageServer` - It gets us one step closed to opening and editing documents in `syntactic_only` mode. The only thing that is left now are semantic tokens.
ahoppen
force-pushed
the
ahoppen/unify-diagnostics
branch
from
47a6f5a to
4086874
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of listening for document updates sent from
sourcekitdand sending aPublishDiagnosticsNotificationbased on thesourcekitdnotification, wait for a little while and then execute an internalDocumentDiagnosticsRequestto load diagnostics and send them to the client.This has two advantages:
SwiftLanguageServersyntactic_onlymode. The only thing that is left now are semantic tokens.