Revert "Fix accidentally-introduced warnings and regression in test behavior in PIFLoadingTests" #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrawdon
requested review from
jakepetroules,
mirza-garibovic,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
grynspan
reviewed
Feb 10, 2025
neonichu
approved these changes
Feb 10, 2025
…ehavior in PIFLoadingTests" The original code was correct and these changes overlooked some context as to why the original code was the way it was (e.g., the warnings are due to a compiler bug, #require will already emit an issue). But we can work around most of the warnings by casting to an optional, which is low-profile and allows us to retain the same approach to these checks, so that has been added where possible. This reverts commit a6a6bb7.
mhrawdon
force-pushed
the
mhrawdon/revert-PIFLoadingTests-changes
branch
from
79a9fd0 to
d4eb98c
Compare
Contributor
Author
|
@swift-ci test |
|
I can offer a workaround, it's just unsightly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was correct and these changes overlooked some context as to why the original code was the way it was (e.g., the warnings are due to a compiler bug,
#requirewill already emit an issue).This reverts commit a6a6bb7.