Add INFOPLIST_KEY_NSViewGestureRecognizerIsExclusive build setting#1448
Merged
Conversation
Adds the build setting so AppKit project templates can set the NSViewGestureRecognizerIsExclusive Info.plist key through GENERATE_INFOPLIST_FILE.
willpaceley
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Author
|
@swift-ci test |
owenv
approved these changes
Jun 9, 2026
added 2 commits
June 10, 2026 10:14
WKSupportsLiveActivityLaunchAttributeTypes is not yet documented, so add it to the URL-reachability exception list in infoPlistKeyConfigurations. NSFocusStatusUsageDescription, NSSystemExtensionUsageDescription, NSVoIPUsageDescription, and OSBundleUsageDescription are now documented, so remove them from the list.
When CHECK_INFOPLIST_KEY_URL_REACHABILITY is set, the check collected the URLs that returned HTTP 200 and recorded those as unreachable, and threw on the first non-200 so the remaining URLs were never checked. Collect only the URLs that fail to return HTTP 200, without aborting on the first failure, so the test reports the URLs that are actually unreachable.
Author
|
@swift-ci test |
jakepetroules
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
NSViewGestureRecognizerIsExclusiveInfo.plist key as anINFOPLIST_KEY_*build setting alongside the other macOS Info.plist keys. The build setting's description links to the key's official documentation using the standard Info.plist documentation URL format.Updates the documentation exception list in
SpecRegistryTests. I removed several keys that are now documented and added the still-undocumentedWKSupportsLiveActivityLaunchAttributeTypes.This PR also fixes the URL reachability check (
CHECK_INFOPLIST_KEY_URL_REACHABILITY), which recorded reachable URLs as unreachable and aborted on the first failure; it now reports only URLs that fail to return a 200 status code as originally intended. TheinfoPlistKeyConfigurations()is now passing and green with my changes.