Fix two trivial build warnings in SWBCore and SWBBuildSystemTests#1468
Merged
daveinglis merged 1 commit intoJun 18, 2026
Merged
Conversation
- GenerateEmbedInCodeAccessor: demote unused `public import SWBUtil` to a
plain import. No SWBUtil type appears in the file's public API, so the
public import only triggered an "unused public import" warning.
- SwiftDriverTests.basicsSwift4_2: drop a redundant `try` on the
non-throwing TestWorkspace(...) initializer.
rdar://175924223
rdar://175556492
daveinglis
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
mhrawdon
approved these changes
Jun 17, 2026
owenv
approved these changes
Jun 17, 2026
jakepetroules
approved these changes
Jun 17, 2026
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public import SWBUtilto a plain import. No SWBUtil type appears in the file's public API, so the public import only triggered an "unused public import" warning.tryon the non-throwing TestWorkspace(...) initializer.rdar://175924223
rdar://175556492