[6.4.x] Use Swift SDK manifest path as imposed SDKROOT during specialization#1495
Merged
Conversation
Strengthen `wasmSwiftSDKDependencySpecialization` test Apply suggestions from code review Co-authored-by: Max Desiatov <m_desiatov@apple.com> Update test to be host-platform-agnostic
owenv
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
rconnell9 and
rjmansfield
as code owners
Collaborator
Author
|
@swift-ci test |
jakepetroules
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates @MaxDesiatov's changes in #1326 to tweak a few comments, and update the test so it can run on a non-macOS host OS. I've also tested it against @kateinoigakukun's updated reproducer in swiftlang/swift-package-manager#10228.