[6.4] Add SWIFTC_DISABLE_SANDBOX Swift compiler xcspec settings#1498
Merged
Conversation
bkhouri
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
owenv,
rconnell9 and
rjmansfield
as code owners
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Jun 30, 2026
Some package systems (e.g: HomeBrew, Nix) use a custom build sandbox. Within the outer sandbox, Swift Toolchain should not create their own sandbox, which is why SwiftPM offers a `--disable-sandbox` options. The option is inneffective in Swift toolchain included with Xcode Beta (Xcode 27A5194q, Swift 6.4.0.20.104). Add a test to ensure the issues does not regress. Relates to: swiftlang#7098 Depends on: swiftlang/swift-build#1498 Issue: rdar://179641209
owenv
approved these changes
Jun 30, 2026
owenv
left a comment
owenv
left a comment
Collaborator
There was a problem hiding this comment.
lgtm aside from one comment on the test
bkhouri
force-pushed
the
t/6.4.x/rdar179641209_disable-sandbox_regress_add_SWIFTC_DISABLE_SANDBOX_build_setting
branch
from
88e71f2 to
6c11adb
Compare
Contributor
Author
|
@swift-ci test |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Jul 1, 2026
Some package systems (e.g: HomeBrew, Nix) use a custom build sandbox. Within the outer sandbox, Swift Toolchain should not create their own sandbox, which is why SwiftPM offers a `--disable-sandbox` options. The option is inneffective in Swift toolchain included with Xcode Beta (Xcode 27A5194q, Swift 6.4.0.20.104). Add a test to ensure the issues does not regress. Relates to: swiftlang#7098 Depends on: swiftlang/swift-build#1498 Issue: rdar://179641209
jakepetroules
approved these changes
Jul 1, 2026
bkhouri
force-pushed
the
t/6.4.x/rdar179641209_disable-sandbox_regress_add_SWIFTC_DISABLE_SANDBOX_build_setting
branch
from
6c11adb to
dbf2652
Compare
Contributor
Author
|
@swift-ci test |
Some package systems (e.g: HomeBrew, Nix) use a custom build sandbox. Within the outer sandbox, Swift Toolchain should not create their own sandbox, which is why SwiftPM offers a `--disable-sandbox` options. Add a Swift compiler XCSpec setting that, when set, passes the respective command line argument to the swiftc compiler. Relates to: swiftlang/swift-package-manager#7098 Issue: rdar://179641209
bkhouri
force-pushed
the
t/6.4.x/rdar179641209_disable-sandbox_regress_add_SWIFTC_DISABLE_SANDBOX_build_setting
branch
from
dbf2652 to
f8cb6c9
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
The same builds are failing against #1507, which only modified GitHub Actions. This gives me more confidence that CI failures are unrelated to this PR. As a result, I'm going to merge the PR. |
bkhouri
deleted the
t/6.4.x/rdar179641209_disable-sandbox_regress_add_SWIFTC_DISABLE_SANDBOX_build_setting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some package systems (e.g: HomeBrew, Nix) use a custom build sandbox. Within the outer sandbox, Swift Toolchain should not create their own sandbox, which is why SwiftPM offers a
--disable-sandboxoptions.Add a Swift compiler XCSpec setting that, when set, passes the respective command line argument to the swiftc compiler.
Relates to: swiftlang/swift-package-manager#7098
Issue: rdar://179641209
Issue: rdar://FB23149934 (Customer Feedback)