Drop x86_64 from simulator builds at deployment targets 27+#1505
Merged
Conversation
Mirrors the existing macOS x86_64 clamp, for the iOS, tvOS, watchOS and xrOS simulators. Adds a test covering the clamped (arm64-only) behavior. resolves: rdar://179972645 assisted by Claude Opus 4.8
cyndyishida
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
owenv,
rconnell9 and
rjmansfield
as code owners
owenv
approved these changes
Jul 2, 2026
owenv
left a comment
owenv
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but there may be further test failures that need to be fixed
Contributor
Author
|
@swift-ci please test |
Contributor
Author
👍 My hope is that #1497 covered them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the existing macOS x86_64 clamp for the iOS, tvOS, watchOS, and visionOS simulators. Adds a test covering the clamped behavior.
resolves: rdar://179972645
assisted by Claude Opus 4.8