-
Notifications
You must be signed in to change notification settings - Fork 90
Add an Environment type to represent environment variables #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
@@ -12,25 +12,157 @@ | |||
|
|||
import Foundation | |||
|
|||
@TaskLocal fileprivate var processEnvironment = ProcessInfo.processInfo.environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore the "diffs" in this file. This PR is entirely additions; the original Environment.swift was renamed to EnvironmentHelpers.swift.
@swift-ci test windows |
@swift-ci test |
@swift-ci test windows |
If you want to apply it somewhere, TouchTool could use some love.
|
@swift-ci test |
1 similar comment
@swift-ci test |
This starts with a slightly modified version of the implementation from SwiftPM. This is not yet adopted anywhere, it's just adding the initial implementation. Closes #186
@swift-ci test |
Coming in a follow-on PR :) |
@jakepetroules I am afraid your last patch causes a compile failure on Windows:
Attaching the full lo here: swift-main-windows-toolchain-arm64-1060.log As a result the nightly builds fail and PR testing is stuck. I will prepare a revert. Please let me know if you have a better proposal. |
This starts with a slightly modified version of the implementation from SwiftPM. This is not yet adopted anywhere, it's just adding the initial implementation.
Closes #186