Skip to content

Add swift version file to record the Swift toolchain to use#509

Merged
jakepetroules merged 1 commit into
mainfrom
t/main/add_swift-version
May 29, 2025
Merged

Add swift version file to record the Swift toolchain to use#509
jakepetroules merged 1 commit into
mainfrom
t/main/add_swift-version

Conversation

@bkhouri

@bkhouri bkhouri commented May 15, 2025

Copy link
Copy Markdown
Contributor

When working with SwiftBuild, there is a particular version that development is expected to use so that all of the compilers, standard libraries, test frameworks, etc. are expected to be working. The .swift-version file establishes a standard way to record this information. Also, there is tooling available through swiftly to use that information to automatically use the correct toolchain in any git commit to set the developer's toolchain when they run and test the package functions at desk.

Create the .swift-version file and set it to the current expected toolchain version: 6.1.

@bkhouri

bkhouri commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

Comment thread .swift-version Outdated
When working with SwiftBuild, there is a particular version that
development is expected to use so that all of the compilers, standard
libraries, test frameworks, etc. are expected to be working. The
`.swift-version` file establishes a standard way to record this
information. Also, there is tooling available through `swiftly` to use
that information to automatically use the correct toolchain in any git
commit to set the developer's toolchain when they run and test the
package functions at desk.

Create the `.swift-version` file and set it to the current expected
toolchain version: 6.1.
@bkhouri bkhouri force-pushed the t/main/add_swift-version branch from 9e0c823 to 3128675 Compare May 15, 2025 02:36
@bkhouri

bkhouri commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review May 15, 2025 02:36
@neonichu

Copy link
Copy Markdown
Collaborator

I think we need to update the README in conjunction with this? There we're saying that Xcode 16.2 is supported, which ships with Swift 6.0.3.

@jakepetroules

Copy link
Copy Markdown
Collaborator

I think we need to update the README in conjunction with this? There we're saying that Xcode 16.2 is supported, which ships with Swift 6.0.3.

Well, it should at least say "or later", it doesn't make sense to say that an exact version is supported. But I don't think we broke it.

@neonichu

neonichu commented May 15, 2025

Copy link
Copy Markdown
Collaborator

But I don't think we broke it.

Right, we didn't break it, yet, but this PR also ensures that we won't really test it anymore (presuming we'll follow the .swift-version elsewhere). IMHO, the minimum version we document and .swift-version should align.

@jakepetroules

Copy link
Copy Markdown
Collaborator

But I don't think we broke it.

Right, we didn't break it, yet, but this PR also ensures that we won't really test it anymore (presuming we'll follow the .swift-version elsewhere). IMHO, the minimum version we document and .swift-version should align.

Sounds fine to me.

@bkhouri

bkhouri commented May 22, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@jakepetroules

Copy link
Copy Markdown
Collaborator

According to #523, it looks like we did break it, so I think we should update the README to say Xcode 16.3, then.

@jakepetroules

Copy link
Copy Markdown
Collaborator

Let's handle the versioning separately; CI is still on 16.2 actually, so technically we can't claim to require 16.3 quite yet.

@jakepetroules jakepetroules merged commit 4bb431e into main May 29, 2025
3 checks passed
@jakepetroules jakepetroules deleted the t/main/add_swift-version branch May 29, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants