Allow Asset Catalog compiler spec to properly opt out of requiring Text-Based API#566
Merged
Merged
Conversation
matthewseaman
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
jakepetroules
approved these changes
Jun 7, 2025
owenv
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our effort to move file-type specific logic away from the Core Build System layers, we'd like to start removing some of the hacks that were put in place for Asset Catalogs.
Here, I've allowed the Asset Catalog Compiler spec to opt out of requiring TAPI to be enabled on the target. This is very specific to how Asset Catalogs opt into
installapifor symbol generation but don't actually publish any real API that would require TAPI.This way we don't need
FilesBasedBuildPhaseTaskProducerto have any special knowledge of Asset Catalogs.