Skip to content

Fixup cross platform specs handling of DEAD_CODE_STRIPPING#576

Merged
owenv merged 1 commit into
mainfrom
owenv/dead-strip
Jun 12, 2025
Merged

Fixup cross platform specs handling of DEAD_CODE_STRIPPING#576
owenv merged 1 commit into
mainfrom
owenv/dead-strip

Conversation

@owenv

@owenv owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

Properly handle the various spellings of this operation

@owenv

owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@swift-ci test

Comment thread Tests/SWBTaskConstructionTests/TaskConstructionTests.swift Outdated
@jakepetroules

Copy link
Copy Markdown
Collaborator

Linux:

✘ Test linkerTaskConstruction() recorded an issue at CommandLineSpecTests.swift:1277:30: Expectation failed: (actual → ["clang", "-Xlinker", "-rpath", "-Xlinker", "rpath1", "-nostdlib", "-dead_strip", "-lfoo_normal_search", "-lfoo_reexport_search", "-lfoo_merge_search", "-lfoo_reexport_merge_search", "-weak-lfoo_weak_search", "/usr/lib/libfoo_normal_abs.a", "/usr/lib/libfoo_reexport_abs.a", "/usr/lib/libfoo_merge_abs.a", "/usr/lib/libfoo_reexport_merge_abs.a", "-weak_library", "/usr/lib/libfoo_weak_abs.a", "-lbar_normal_search", "-Xlinker", "-reexport-lbar_reexport_search", "-Xlinker", "-merge-lbar_merge_search", "-Xlinker", "-no_merge-lbar_reexport_merge_search", "-weak-lbar_weak_search", "/usr/lib/libbar_normal_abs.dylib", "-Xlinker", "-reexport_library", "-Xlinker", "/usr/lib/libbar_reexport_abs.dylib", "-Xlinker", "-merge_library", "-Xlinker", "/usr/lib/libbar_merge_abs.dylib", "-Xlinker", "-no_merge_library", "-Xlinker", "/usr/lib/libbar_reexport_merge_abs.dylib", "-weak_library", "/usr/lib/libbar_weak_abs.dylib", "-lbaz_normal_search", "-lbaz_reexport_search", "-lbaz_merge_search", "-lbaz_reexport_merge_search", "-weak-lbaz_weak_search", "/usr/lib/libbaz_normal_abs.tbd", "/usr/lib/libbaz_reexport_abs.tbd", "/usr/lib/libbaz_merge_abs.tbd", "/usr/lib/libbaz_reexport_merge_abs.tbd", "-weak_library", "/usr/lib/libbaz_weak_abs.tbd", "-framework", "Foo_normal_search", "-Xlinker", "-reexport_framework", "-Xlinker", "Foo_reexport_search", "-Xlinker", "-merge_framework", "-Xlinker", "Foo_merge_search", "-Xlinker", "-no_merge_framework", "-Xlinker", "Foo_reexport_merge_search", "-weak_framework", "Foo_weak_search", "/tmp/Foo_normal_abs.framework/Foo_normal_abs", "-Xlinker", "-reexport_library", "-Xlinker", "/tmp/Foo_reexport_abs.framework/Foo_reexport_abs", "-Xlinker", "-merge_library", "-Xlinker", "/tmp/Foo_merge_abs.framework/Foo_merge_abs", "-Xlinker", "-no_merge_library", "-Xlinker", "/tmp/Foo_reexport_merge_abs.framework/Foo_reexport_merge_abs", "-weak_library", "/tmp/Foo_weak_abs.framework/Foo_weak_abs", "-o", "/tmp/obj/normal/x86_64/output"]) == (expected → ["clang", "-Xlinker", "-rpath", "-Xlinker", "rpath1", "-nostdlib", "-lfoo_normal_search", "-lfoo_reexport_search", "-lfoo_merge_search", "-lfoo_reexport_merge_search", "-weak-lfoo_weak_search", "/usr/lib/libfoo_normal_abs.a", "/usr/lib/libfoo_reexport_abs.a", "/usr/lib/libfoo_merge_abs.a", "/usr/lib/libfoo_reexport_merge_abs.a", "-weak_library", "/usr/lib/libfoo_weak_abs.a", "-lbar_normal_search", "-Xlinker", "-reexport-lbar_reexport_search", "-Xlinker", "-merge-lbar_merge_search", "-Xlinker", "-no_merge-lbar_reexport_merge_search", "-weak-lbar_weak_search", "/usr/lib/libbar_normal_abs.dylib", "-Xlinker", "-reexport_library", "-Xlinker", "/usr/lib/libbar_reexport_abs.dylib", "-Xlinker", "-merge_library", "-Xlinker", "/usr/lib/libbar_merge_abs.dylib", "-Xlinker", "-no_merge_library", "-Xlinker", "/usr/lib/libbar_reexport_merge_abs.dylib", "-weak_library", "/usr/lib/libbar_weak_abs.dylib", "-lbaz_normal_search", "-lbaz_reexport_search", "-lbaz_merge_search", "-lbaz_reexport_merge_search", "-weak-lbaz_weak_search", "/usr/lib/libbaz_normal_abs.tbd", "/usr/lib/libbaz_reexport_abs.tbd", "/usr/lib/libbaz_merge_abs.tbd", "/usr/lib/libbaz_reexport_merge_abs.tbd", "-weak_library", "/usr/lib/libbaz_weak_abs.tbd", "-framework", "Foo_normal_search", "-Xlinker", "-reexport_framework", "-Xlinker", "Foo_reexport_search", "-Xlinker", "-merge_framework", "-Xlinker", "Foo_merge_search", "-Xlinker", "-no_merge_framework", "-Xlinker", "Foo_reexport_merge_search", "-weak_framework", "Foo_weak_search", "/tmp/Foo_normal_abs.framework/Foo_normal_abs", "-Xlinker", "-reexport_library", "-Xlinker", "/tmp/Foo_reexport_abs.framework/Foo_reexport_abs", "-Xlinker", "-merge_library", "-Xlinker", "/tmp/Foo_merge_abs.framework/Foo_merge_abs", "-Xlinker", "-no_merge_library", "-Xlinker", "/tmp/Foo_reexport_merge_abs.framework/Foo_reexport_merge_abs", "-weak_library", "/tmp/Foo_weak_abs.framework/Foo_weak_abs", "-o", "/tmp/obj/normal/x86_64/output"])
↳ Unexpected arguments: ["-dead_strip"]; 

@owenv owenv force-pushed the owenv/dead-strip branch from f751cb7 to 18fcc44 Compare June 11, 2025 22:04
@owenv

owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@swift-ci test

1 similar comment
@owenv

owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@swift-ci test

@owenv

owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@swift-ci test linux

1 similar comment
@owenv

owenv commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

@swift-ci test linux

@owenv owenv merged commit 590f502 into main Jun 12, 2025
24 checks passed
@owenv owenv deleted the owenv/dead-strip branch June 12, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants