Move duplicated code into its own function. #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtibbetts
approved these changes
Apr 24, 2019
To allow easier adoption of the Android code, this duplicated piece of code is moved into its own function, since it will need to change significantly for Android.
drodriguez
force-pushed
the
extract-time-zone-data-create
branch
from
29d396b to
ab183ec
Compare
|
Found two more instances of the same code. |
compnerd
approved these changes
Apr 24, 2019
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow easier adoption of the Android code, this duplicated piece of
code is moved into its own function, since it will need to change
significantly for Android.
As requested in #2168.