FileHandle: improve the compatibility of synchronize
#3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestFileHandle/test_synchronizeOnSpecialFile introduced a failure in the Windows test suite. The underlying problem here is that `FlushFileBuffers` is not permitted on unbuffered file handles (such as consoles). Ensure that we do not treat errors on character devices as flush errors.
Contributor
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFileHandle/test_synchronizeOnSpecialFile introduced a failure in the
Windows test suite. The underlying problem here is that
FlushFileBuffersis not permitted on unbuffered file handles (such asconsoles). Ensure that we do not treat errors on character devices as
flush errors.