Skip to content

Foundation: make some functions more visible #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2022

Conversation

compnerd
Copy link
Member

These ivars and functions are referenced elsewhere in Foundation. We
were previously relying on the compiler exporting functions more
aggressively which would ensure that these were emitted even when not
meant to be used outside of the current module. This marks these
interfaces as internal to ensure that references from other source
files are emitted with more aggressive internalization by the compiler.

These ivars and functions are referenced elsewhere in Foundation.  We
were previously relying on the compiler exporting functions more
aggressively which would ensure that these were emitted even when not
meant to be used outside of the current module.  This marks these
interfaces as `internal` to ensure that references from other source
files are emitted with more aggressive internalization by the compiler.
@millenomi
Copy link
Contributor

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please test

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift#41115

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift#41204

@swift-ci please test macOS platform

@compnerd compnerd merged commit 2ab55d9 into swiftlang:main Feb 20, 2022
@compnerd compnerd deleted the visibility branch February 20, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants