-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[EXPERIMENTAL] Add support for vcpkg #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Anyone to review? |
Pulling the brake on this one because I'd like an explanation of benefits. How does this benefit the Visual Studio story at all? Are you building a VS build solution for Swift itself? CMake is an internal build detail of Swift itself and I would prefer people do not attempt to maintain their own CMake-based build setups for end user software. ( |
(Yes, it is clear that SPM has Windows issues aplenty, but the focus should be if possible on those rather than exposing build details of a module that should be picked up with the redistributable instead.) |
@millenomi This adds a manifest file of
flag passed on CMake, to let
Like we’re using CMake as an alternative to SwiftPM somewhere, |
I'm not super willing to add support for something we don't have a CI test rig for, sorry. Is it something you can maintain in your fork? |
And whoops I shouldn't have assumed this was VS-related, my bad. |
Do you have a use case that works with CMake, but not SPM? Is there anything blocking you from using SPM instead? |
I don’t think any of the core libraries can be built with SwiftPM from ever since. We’re either using CMake or custom The main purpose of introducing |
The case of |
Windows developers have a relatively difficult experience for pulling in dependencies. This patch adds support for
vcpkg
's manifest mode, which can seamlessly integrate with CMake.