Process: unwrap the posix_spawnattr_t on Android
#5179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as while `posix_spawnattr_init` permits a nullable type, `posix_spawnattr_setflags` properly expects a non-null parameter. Unwrap the newly minted spawnattr or abort if the allocation failed.
|
CC: @finagolfin The revert was incorrect, the unwrapping should always be present. However, the position of the unwrapping was incorrect. Even with the older SDK, the unwrapping should occur after the This has only been tested with r27c, but I expect it to be backwards compatible with r26b and the Android SDK that we are currently shipping on main. |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
finagolfin
approved these changes
Feb 28, 2025
hjyamauchi
added a commit
that referenced
this pull request
Mar 5, 2025
This is required as while `posix_spawnattr_init` permits a nullable type, `posix_spawnattr_setflags` properly expects a non-null parameter. Unwrap the newly minted spawnattr or abort if the allocation failed. Cherry pick commit #5179
finagolfin
pushed a commit
that referenced
this pull request
Mar 6, 2025
This is required as while `posix_spawnattr_init` permits a nullable type, `posix_spawnattr_setflags` properly expects a non-null parameter. Unwrap the newly minted spawnattr or abort if the allocation failed. Cherry pick commit #5179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required as while
posix_spawnattr_initpermits a nullable type,posix_spawnattr_setflagsproperly expects a non-null parameter. Unwrap the newly minted spawnattr or abort if the allocation failed.