Fix edge case issue where tutorials-overview bg may appear light #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations with no footer and a long viewport height and little actual content, the background of the empty space will be white. It should be a darker fill color in any light/dark/auto appearance since that page purposefully has an "always-dark" design theme.
|
@swift-ci test |
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Jul 18, 2023
…iftlang#719) In situations with no footer and a long viewport height and little actual content, the background of the empty space will be white. It should be a darker fill color in any light/dark/auto appearance since that page purposefully has an "always-dark" design theme. Resolves: rdar://108634043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 108634043
Summary
In situations with no footer and a long viewport height and little actual content, the background of the empty space will be white.
It should be a darker fill color in any light/dark/auto appearance since that page purposefully has an "always-dark" design theme.
Testing
Steps:
VUE_APP_TARGET=ideand verify that the empty space in a tall viewport appears dark instead of light, regardless of the user's overall light/dark/auto preference.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
Added tests(CSS-only change)npm test, and it succeeded