Android: add the right suffix for the compiler-rt profiler library #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
approved these changes
Aug 26, 2024
Contributor
|
@swift-ci test |
Member
Author
|
Do I still need to submit the equivalent pull for the legacy C++ driver too, or do we not have to bother as much anymore, especially since that Driver is going away and this is a niche usecase? |
Contributor
I'd say that's not necessary unless you can come up with some kind if niche requirements for where the legacy driver is needed. My hope is that it isn't. |
Member
Author
|
Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of profiler tests in the compiler validation suite were recently enabled on non-Darwin platforms by swiftlang/swift#75572 and then failed natively on Android because they couldn't find this profiler library, which this pull fixed. This is the same change I used to find the sanitizer libraries for Android a couple years ago.