Skip to content

Clean up owned ArgsResolver temporary directories - #2168

Draft
aryansk wants to merge 1 commit into
swiftlang:mainfrom
aryansk:codex/issue-1720-temp-cleanup
Draft

Clean up owned ArgsResolver temporary directories#2168
aryansk wants to merge 1 commit into
swiftlang:mainfrom
aryansk:codex/issue-1720-temp-cleanup

Conversation

@aryansk

@aryansk aryansk commented Aug 8, 2026

Copy link
Copy Markdown

Fixes #1720

What changed

  • Track ownership of the temporary directory created internally by ArgsResolver.
  • Remove internally-owned temporary directories during resolver deinitialization while preserving caller-owned directories.
  • Keep explicit cleanup behavior intact and add a regression test for deinitialization cleanup.

Validation

  • swift test --filter JobExecutorTests.temporaryDirectoryIsRemovedOnResolverDeinit — 1 test passed.
  • The checkout retains existing compiler warnings; the focused test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArgsResolver does not clean up temporary files

1 participant