Skip to content

OrderedImports should create separate groups for different access levels #703

Open
@allevato

Description

@allevato

Now that public/internal/private/etc import is supported, we should have the OrderedImports rule do separate groupings for each access level. Order the groups in descending order of access level (public, package, internal, fileprivate/private), with each group sorted lexicographically as usual.

Other details:

  • If a user has both internal import and import, do we unify them by adding/removing internal? We don't currently add or drop internal anywhere else, so we don't have a precedent here.
  • We do need to respect the fileprivate/private configuration that's used for other file-scoped declarations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions