Remove the swift-tools-support-core dependency from swift-format.#509
Merged
allevato merged 1 commit intoswiftlang:mainfrom Apr 11, 2023
Merged
Remove the swift-tools-support-core dependency from swift-format.#509allevato merged 1 commit intoswiftlang:mainfrom
swift-tools-support-core dependency from swift-format.#509allevato merged 1 commit intoswiftlang:mainfrom
Conversation
This was only being used for the diagnostics engine, which is easy enough to roll by hand and it's one less dependency to keep in sync with the rest of the toolchain. In the future, we may want an output mode that uses the new prettier diagnostic printer from swift-syntax.
Member
Author
|
cc @dylansturg |
dylansturg
approved these changes
Apr 10, 2023
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jun 29, 2023
Remove the `swift-tools-support-core` dependency from swift-format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only being used for the diagnostics engine, which is easy enough to roll by hand and it's one less dependency to keep in sync with the rest of the toolchain.
In the future, we may want an output mode that uses the new prettier diagnostic printer from swift-syntax.