Split the PrettyPrint class into two pieces.#759
Merged
allevato merged 2 commits intoswiftlang:mainfrom Jun 27, 2024
Merged
Conversation
This change breaks up the PrettyPrint class into one piece that is responsible for tracking the state of the pretty printing algorithm - processing the tokens, tracking the break stack, comma delimited region stack, etc.; and another piece that is responsible for assembling the output and tracking the state of the output - current line, column position, and indentation.
Contributor
Author
|
I did this as a learning exercise, to separate out the state that was part of the algorithm vs. the state that was part of the output stream. To me it makes things a bit easier to grok, interested in your thoughts on it. |
allevato
reviewed
Jun 26, 2024
Member
allevato
left a comment
allevato
left a comment
There was a problem hiding this comment.
Interesting idea! I think this looks really good; the algorithm has gotten more complex over time as we've needed to add new features to the original, and I like that this moves the much of the "number fudging" (i.e., direct math operations) down to a lower layer and making the core algorithm read a bit more semantically.
|
|
||
| import Foundation | ||
|
|
||
| struct PrettyPrintBuffer { |
Member
There was a problem hiding this comment.
Please add a brief doc comment for this type and for the stored properties below.
allevato
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change breaks up the PrettyPrint class into one piece that is responsible for tracking the state of the pretty printing algorithm - processing the tokens, tracking the break stack, comma delimited region stack, etc.; and another piece that is responsible for assembling the output and tracking the state of the output - current line, column position, and indentation.