Fix NoEmptyLinesOpeningClosingBraces to respect consecutive newlines when a function starts or ends with a comment#910
Merged
allevato merged 1 commit intoswiftlang:mainfrom Jan 7, 2025
Conversation
…when a function starts or ends with a comment
TTOzzi
requested review from
ahoppen,
allevato,
bnbarham and
shawnhyam
as code owners
allevato
approved these changes
Jan 6, 2025
Member
allevato
left a comment
allevato
left a comment
There was a problem hiding this comment.
Looks reasonable to me, thanks!
Member
|
I'll kick off the full CI, which should at least make sure that this PR doesn't change the expected formatting of swift-syntax as a safety check. |
Member
Author
|
Thank you! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #909
Since we are traversing the
leadingTriviain order to determine whether newlines are respected, we needed to modify thetrimmingSuperfluousNewlinesfunction to distinguish whether theleadingTriviawe are traversing is the beginning or end of a block.For the
leadingTriviaof theclosingBrace, the handling of newlines was deferred and revised to process them only when the nextTriviaPieceis neither a space/tab nor a newline.