Upgrade to ICU 74 #39
Conversation
iCharlesHu
force-pushed
the
charles/icu-74
branch
2 times, most recently
from
dd6e383 to
3969251
Compare
|
Toolchain build test: swiftlang/swift#75452 |
| @@ -11,7 +11,7 @@ | |||
| // | |||
|
|
|||
| /* | |||
| These are defined before _foundation_unicode/uversion.h in order to prevent | |||
| These are defined before unicode/uversion.h in order to prevent | |||
There was a problem hiding this comment.
It's not important here since it's just a comment, but should we tweak your script to apply another round of /s/unicode/_foundation_unicode after the merge, in case we miss places where this difference really matters?
There was a problem hiding this comment.
Just testing unicode/*h might work... But I'm feeling somewhat nervous by that so I'd rather test #include unicode/*.h... IMO the comments are fine since we don't really manually edit the code anyways.
| @@ -239,17 +239,17 @@ enum { | |||
|
|
|||
| /* InsertPoints structure for noting where to put BiDi marks ---------------- */ | |||
|
|
|||
| typedef struct _Point { | |||
There was a problem hiding this comment.
Confirmed in private that this should no longer be an issue since #34
| target_sources(_FoundationICU | ||
| PRIVATE | ||
| alphaindex.cpp |
There was a problem hiding this comment.
This file doesn't seem to be new. Any idea why this wasn't included in this cmake file before?
There was a problem hiding this comment.
I think we might have just forgotten to include it and got lucky with it 😓
Now these CMakeList files are auto generated so we shouldn't have this problem anymore.
iCharlesHu
force-pushed
the
charles/icu-74
branch
from
8788156 to
2a70a46
Compare
|
Squashed all commits |
This patches brings
swift-foundation-icuto ICU 74, which is the same version shipped in macOS Sonoma