Skip to content

WiX: remove workaround for mimalloc #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 9, 2025

Remove the extra library packaging which was a workaround for mimalloc adding a reference to foreign architecture modules.

Remove the extra library packaging which was a workaround for mimalloc
adding a reference to foreign architecture modules.
@compnerd
Copy link
Member Author

Associated change: swiftlang/swift#80681

Tested the ARM64 build on a Parallels VM

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/mimalloc#997 is still open.
Though it's in v3.0.3, that version appears to be a beta release.

Latest release : v3.0.3 (beta) (2025-03-28).

Does this affect 6.1? If so, I'm a bit concerned about the implications of a fully released toolchain and SDK switching to using beta libraries in its runtimes.

Does this affect 6.2? If so, will the fix be in a proper release of mimalloc by the time 6.2 is released?

@compnerd
Copy link
Member Author

This isn't going to 6.1, its too late for that. Maybe 6.1.1, but I don't think that this is urgent there.

I'd like this to go to 6.2 as well. This library is only used by the compiler not the runtime. The runtime still uses the system allocator. While it is interesting to consider the swap there, I don't think that is an immediate priority.

We are currently on 3.0.1, which was arguably "alpha". The big changes here are related to enabling ARM64 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants