[FreeBSD] Fix target conditionals for FreeBSD aarch64 builds #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite being declared in the header unistd.h, the function sbrk is not available on FreeBSD when using the aarch64 architecture because FreeBSD make the decision to drop support for this deprecated function when porting the system to ARM. The configuration script incorrectly hard-codes the support for this function as being always available, which is not correct. We need to ensure that it is not used on FreeBSD aarch64.
jakepetroules
approved these changes
May 6, 2025
|
@swift-ci test |
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
dmbryson
approved these changes
May 7, 2025
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
|
@swift-ci test linux |
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being declared in the header unistd.h, the function
sbrkis not available on FreeBSD when using the aarch64 architecture because FreeBSD made the decision to drop support for this deprecated function when porting the system to ARM.The configuration script incorrectly hard-codes the support for this function as being always available, which is not correct. We need to ensure that it is not used on FreeBSD aarch64.