[6.4.x] Fix reporting of builtArtifacts to command plugins when the umbrella test product is requested#10245
Merged
Conversation
…test product is requested
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
Contributor
Author
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a command plugin requested the builtArtifacts corresponding to a request to build the PackageTests umbrella product, we would incorrectly report no artifacts when using the Swift Build backend. Track artifacts which correspond to the umbrella test product to ensure they are reported correctly.
Resolves #10227 (but I need to polish up and land swiftlang/swift-build#1326 to avoid running into a secondary issue)