Use host triple in createIndexStoreAPI #2780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
aciidgh
approved these changes
Jun 10, 2020
78 tasks
|
@swift-ci please smoke test |
|
@neonichu I've pushed the fix for Linux tests, |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the
--enable-test-discoveryflag SwiftPM looks forlibIndexStoreusing the target triple if one was present, instead of the host triple. This breaks when cross-compiling, since you actually needlibIndexStorefrom the host, not the target. This is resolved by adding a newhostTripleproperty, as opposed to the existing targettripleproperty. NewhostTripleis used increateIndexStoreAPIto infer the extension oflibIndexStorewhen searching for it.