Mirrors config migration should not modify user's file#3901
Merged
Conversation
Motivation: The migration from `.swiftpm/config` to `.swiftpm/configuration/mirrors.json` moves `.swiftpm/config` and leads user to think that the file gets deleted. (rdar://85917746) Modifications: - Copy `.swiftpm/config` to `.swiftpm/configuration/mirrors.json` instead of moving it. - Emit warning that `.swiftpm/config` has been deprecated. - Don't perform the migration if `.swiftpm/configuration/mirrors.json` already exists to prevent error. (rdar://85917836)
yim-lee
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The migration from
.swiftpm/configto.swiftpm/configuration/mirrors.jsonmoves.swiftpm/configand leads user to think that the file gets deleted. (rdar://85917746)Modifications:
.swiftpm/configto.swiftpm/configuration/mirrors.jsoninstead of moving it..swiftpm/confighas been deprecated..swiftpm/configuration/mirrors.jsonalready exists to prevent error. (rdar://85917836)