Stop using --gc-sections for Wasm target to protect metadata sections#5638
Merged
MaxDesiatov merged 1 commit intoJul 10, 2022
Merged
Conversation
kateinoigakukun
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
Member
Author
|
@swift-ci Please smoke test |
MaxDesiatov
approved these changes
Jul 3, 2022
keith
approved these changes
Jul 5, 2022
keith
left a comment
keith
left a comment
Member
There was a problem hiding this comment.
seems good, we should definitely do that TODO for binary size sake
abertelrud
reviewed
Jul 5, 2022
abertelrud
approved these changes
Jul 7, 2022
Now wasm-ld strips data segments referenced through __start/__stop symbols during GC, and it removes Swift metadata sections like swift5_protocols We should add support of SHF_GNU_RETAIN-like flag for __attribute__((retain)) to LLVM and wasm-ld. For now, just disable section GC for Wasm target.
kateinoigakukun
force-pushed
the
katei/void-gc-sections-on-wasm
branch
from
4f68200 to
9722969
Compare
Member
Author
|
@swift-ci Please smoke test |
kateinoigakukun
added a commit
to swiftwasm/swift-package-manager
that referenced
this pull request
Jul 10, 2022
…ns (swiftlang#5638) Now wasm-ld strips data segments referenced through __start/__stop symbols during GC, and it removes Swift metadata sections like swift5_protocols We should add support of SHF_GNU_RETAIN-like flag for __attribute__((retain)) to LLVM and wasm-ld. For now, just disable section GC for Wasm target. Context: llvm/llvm-project#55839 https://reviews.llvm.org/D126950#3558050
tomerd
pushed a commit
that referenced
this pull request
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using --gc-sections for Wasm target to protect metadata sections
Motivation:
Now wasm-ld strips data segments referenced through __start/__stop symbols
during GC, and it removes Swift metadata sections like swift5_protocols.
This option has been added in #4135
Modifications:
We should add support for SHF_GNU_RETAIN-like flag for attribute((retain))
to LLVM and wasm-ld.
For now, just disable section GC for Wasm target.
Context
Result:
Swift metadata sections are retained in the final executable in release configuration for Wasm target.
CC: @MaxDesiatov @keith