Remove --gc-sections for all targets for now #5707
Conversation
Similar to the comment here about wasm-ld, lld recently switched a default that broke this for all elf targets. This is a low risk fix since we weren't passing this flag before either. People who really need this behavior can still pass something like `-Xlinker --gc-sections -Xlinker -z -Xlinker nostart-stop-gc`
|
Ideally we can fix this instead with swiftlang/swift#60357, but if that PR isn't enough, this might be necessary in the short term. |
|
Can we just apply this as a short-term fix for the 5.7 branch, or do all 5.7 fixes have to go into trunk first? Your stdlib pull will fix trunk and there's no urgency with trunk, only 5.7. |
|
here's a 5.7 PR #5708 |
|
@keith should we get this merged into main first, then 5.7? |
|
@swift-ci smoke test |
keith
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
yea there was a question of if we could only do 5.7 and try to solve the core issue without reverting on main, but whatever the process is is fine with me. we can always revert this if we can solve the core issue too |
|
I rather keep them symmetrical so we dont have a later regression, then we can revert / reintroduce when ready? |
|
yep sounds fine! |
|
@swift-ci please test windows platform |
|
I doubt the windows failure here is related, it seems to be timing out |
|
@compnerd okay to merge even with the windows failure? |
|
I think that a retest should help - the offending change was reverted. |
|
@swift-ci please test Windows platform |
It should work with lld now that the lld flag '-z nostart-stop-gc' was added with swiftlang/swift#60544 and swiftlang/swift-driver#1153.
It should work with lld now that the lld flag '-z nostart-stop-gc' was added with swiftlang/swift#60544 and swiftlang/swift-driver#1153.
Similar to the comment here about wasm-ld, lld recently switched a
default that broke this for all elf targets. This is a low risk fix
since we weren't passing this flag before either. People who really need
this behavior can still pass something like
-Xlinker --gc-sections -Xlinker -z -Xlinker nostart-stop-gcFixes #5698