Skip to content

Fix PluginInvocationTests.testCompilationDiagnostics() to avoid throwing if no diagnostics at all are reported #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix PluginInvocationTests.testCompilationDiagnostics() to avoid throwing if no diagnostics at all are reported #6080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tests/SPMBuildCoreTests/PluginInvocationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,11 @@ class PluginInvocationTests: XCTestCase {
let diaFileContents = try localFileSystem.readFileContents(result.diagnosticsFile)
let diagnosticsSet = try SerializedDiagnostics(bytes: diaFileContents)
let hasExpectedDiagnosticsCount = diagnosticsSet.diagnostics.count == 1
let warningDiagnostic = try XCTUnwrap(diagnosticsSet.diagnostics.first)
let hasExpectedWarningText = warningDiagnostic.text.hasPrefix("variable \'unused\' was never used")
let warningDiagnosticText = diagnosticsSet.diagnostics.first?.text ?? ""
let hasExpectedWarningText = warningDiagnosticText.hasPrefix("variable \'unused\' was never used")
if hasExpectedDiagnosticsCount && hasExpectedWarningText {
XCTAssertTrue(hasExpectedDiagnosticsCount, "unexpected diagnostics count in \(diagnosticsSet.diagnostics) from \(result.diagnosticsFile.pathString)")
XCTAssertTrue(hasExpectedWarningText, "\(warningDiagnostic)")
XCTAssertTrue(hasExpectedWarningText, "\(warningDiagnosticText)")
} else {
print("bytes of serialized diagnostics file `\(result.diagnosticsFile.pathString)`: \(diaFileContents.contents)")
try XCTSkipIf(true, "skipping because of unknown serialized diagnostics issue")
Expand Down