Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
| // Enable building macros as dynamic libraries by default for bring-up. | ||
| for target in package.targets.filter({ $0.type == .regular || $0.type == .test }) { | ||
| target.swiftSettings = (target.swiftSettings ?? []) + [ .define("BUILD_MACROS_AS_DYLIBS") ] | ||
| } |
There was a problem hiding this comment.
This essentially flips the logic for now since dylib macros are the only ones which can be tested end-to-end right now.
|
Looks like the self-hosted Linux toolchain understands the flag but doesn't contain the host swift-syntax? Or potentially the search paths are not correct for the Linux toolchain... |
|
Ah no, I commented out the guard for the new test 🙈 |
|
@swift-ci please smoke test |
|
Looks like at least one functional test was broken during the time they were disabled. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Interesting, I did not see this locally, but it does sound correct. |
|
@swift-ci please smoke test |
|
Ah this is now accidentally always thrown |
|
@swift-ci please smoke test |
|
Looks like the new library isn't visible in bootstrapped builds? |
Can repro locally with |
Ah right, the test portion of bootstrapped builds only sees ManifestAPI/PluginAPI modules built by the CMake stage |
|
@swift-ci please smoke test |
|
|
||
| if platform.system() == 'Darwin': | ||
| call(["sed", "-i", "", "s/macosx10.10/macosx%s/" % (g_macos_deployment_target), "build.ninja"], cwd=build_dir) | ||
| call(["sed", "-i", "", "s/CompilerPluginSupport.swiftinterface .*pm\/ManifestAPI\/PackageDescription.swiftinterface/CompilerPluginSupport.swiftinterface/", "build.ninja"], cwd=build_dir) |
There was a problem hiding this comment.
Looks like the way we're building PackageDescription with CMake is fairly broken, we are forcing it to produce a Swift interface, but CMake actually doesn't know about them. We haven't noticed the breakage until now, but since CompilerPluginSupport needs to link it, it surfaces here and needs to be worked around.
|
@swift-ci please smoke test Windows platform |
|
Just noticed the Windows CI job was missing, it seems like maybe it doesn't automatically happen anymore with the standard |
That didn't take long :) |
|
Looks like there's a remaining issue with the bootstrap install process: |
- Add a new module `CompilerPluginSupport` which vends the macro target type - Represent macro targets in the package model - Build system support for macros In order to be able to test this end-to-end before compiler support has landed, we're building macros as dylibs using the `BUILD_MACROS_AS_DYLIBS` flag since that is already supported by the Swift compiler in `main`. The macro API is behind the 999.0 tools version since this has not gone through Swift evolution yet.
|
@swift-ci please smoke test |
|
CI is passing now, I am going to disable the functional tests again. |
|
@swift-ci please smoke test |
2 participants
CompilerPluginSupportwhich vends the macro target typeIn order to be able to test this end-to-end before compiler support has landed, we're building macros as dylibs using the
BUILD_MACROS_AS_DYLIBSflag since that is already supported by the Swift compiler inmain.The macro API is behind the 999.0 tools version since this has not gone through Swift evolution yet.