Skip to content

mark the multi-tool entry point as async #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Mar 9, 2023

motivation: support the package-regsitry tool that is now async

changes: mark SwiftPM multi-tool (which we use in prod) as async and await on regsitry

@tomerd
Copy link
Contributor Author

tomerd commented Mar 9, 2023

@swift-ci smoke test

@@ -21,8 +21,9 @@ let execName = (try? AbsolutePath(validating: firstArg).basenameWithoutExt) ??
(try? RelativePath(validating: firstArg).basenameWithoutExt)

@main
@available(macOS 10.15, macCatalyst 13, iOS 13, tvOS 13, watchOS 6, *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is needed, we already have a macOS 10.15.4 and iOS 13.4 minimum deployment target?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ran into issues with CI if not set. happy to remove this when we bump to macOS 12?

@tomerd
Copy link
Contributor Author

tomerd commented Mar 9, 2023

@compnerd @shahmishal windows build seems to be broken for unrelated reasons:

-- Using Experimental String Processing library for RegexBuilder (C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift-experimental-string-processing).
-- Not building swiftASTGen because swift-syntax is not available
-- Swift version: 5.9
-- Swift vendor: 
-- Swift compiler version: 
-- Embedded clang compiler version: 
-- Not building SwiftMacros because swift-syntax is not available
-- Not building ObservationMacros because swift-syntax is not available
-- Looking for include file xpc/xpc.h
-- Looking for include file xpc/xpc.h - not found
-- Skipping creating early SwiftDriver symlinks - no early SwiftDriver build found.
-- C/C++ compiler for SourceKit is set to: T:/1/./bin/clang-cl.exe
-- Looking for dispatch_block_create
-- Looking for dispatch_block_create - not found
CMake Error: File C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/llvm-project/llvm/stdlib/public/Cxx/std/libstdcxx.modulemap does not exist.
CMake Error at C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/swift/unittests/ClangImporter/CMakeLists.txt:1 (configure_file):
  configure_file Problem configuring file


CMake Warning at C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/swift/unittests/runtime/CMakeLists.txt:19 (message):
  Building the swift runtime using the host compiler, and not the just-built
  clang.

motivation: support the package-regsitry tool that is now async

changes: mark SwiftPM multi-tool (which we use in prod) as async and await on regsitry
@tomerd tomerd force-pushed the fix/multi-tool-async branch from 36c3519 to 7617daa Compare March 9, 2023 05:04
@tomerd
Copy link
Contributor Author

tomerd commented Mar 9, 2023

@swift-ci smoke test macOS

@tomerd
Copy link
Contributor Author

tomerd commented Mar 9, 2023

replaced by #6254

@tomerd tomerd closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants