Expected signing entity verification #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
commented
Mar 31, 2023
| } | ||
| } else { | ||
| // Unsure if this case is reachable in practice. | ||
| throw SigningError.expectedIdentityNotFound(package: identity) |
There was a problem hiding this comment.
I'm not sure how we get into this scenario, so this isn't covered by any tests right now.
There was a problem hiding this comment.
Is this more of an invalid state error?
|
@swift-ci please smoke test |
neonichu
commented
Mar 31, 2023
| try expectedSigningEntities.forEach { identity, expectedSigningEntity in | ||
| if let package = packageGraph.packages.first(where: { $0.identity == identity }) { | ||
| if let actualSigningEntity = package.registryMetadata?.signature?.signedBy { | ||
| if actualSigningEntity != expectedSigningEntity { |
There was a problem hiding this comment.
Should the comparison be more limited?
There was a problem hiding this comment.
What do you have in mind? e.g., must be .recognized?
There was a problem hiding this comment.
Not sure, just posing the question
yim-lee
reviewed
Mar 31, 2023
| } | ||
| } else { | ||
| // Unsure if this case is reachable in practice. | ||
| throw SigningError.expectedIdentityNotFound(package: identity) |
There was a problem hiding this comment.
Is this more of an invalid state error?
This allows clients to pass in a dictionary with expected signing entities that SwiftPM will check after loading the package graph. This can be used by clients to provide a priori configuration of expected signing by the user or provide a way to verify that information that was previously shown to users matches what was verified during signature verification. Note that since this operates at the workspace level, we're verifying against the data cached during signature verification, not against the actual data. rdar://107162424
neonichu
force-pushed
the
expected-signing-entity-verification
branch
from
1ecbcae to
2792132
Compare
|
@swift-ci please smoke test |
|
@swift-ci smoke test macos |
|
@swift-ci test windows |
tomerd
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to pass in a dictionary with expected signing entities that SwiftPM will check after loading the package graph. This can be used by clients to provide a priori configuration of expected signing by the user or provide a way to verify that information that was previously shown to users matches what was verified during signature verification.
Note that since this operates at the workspace level, we're verifying against the data cached during signature verification, not against the actual data.
rdar://107162424