Skip to content

Package: adjust the package definition for Windows #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Package: adjust the package definition for Windows #6394

merged 1 commit into from
Apr 10, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 5, 2023

Aliasing main is not supported on Windows in SPM as of yet. This adjusts the build rules to allow building the test suite on Windows in light of that. While the tests do not yet pass, this allows the package to be built for the remaining tests.

@compnerd
Package: adjust the package definition for Windows
d72319c 
Aliasing `main` is not supported on Windows in SPM as of yet.  This
adjusts the build rules to allow building the test suite on Windows
in light of that.  While the tests do not yet pass, this allows the
package to be built for the remaining tests.
@compnerd compnerd marked this pull request as ready for review April 5, 2023 19:46
@tomerd
Copy link
Contributor

tomerd commented Apr 5, 2023

while I dont mind this change temporarily, what is the outlook on supporting that on Windows? our users will surely want this functionality themselves

@compnerd
Copy link
Member Author

compnerd commented Apr 6, 2023 •
edited
Loading

I don't know of any way to do this at the linker level on Windows. There is no equivalent to --defsym or -alias and the current implementation in SPM results in multiple definitions. I think that we need to work with the compiler to have a general mechanism for renaming the entry point and use that. That would require some coordination between the frontend and SPM but would make this portable and reliable. I think that once we have the tests passing on Windows, we can work together on that and then continue the static/dynamic linking work as well. I'm hesitant to work on anything related to static/dynamic linking as I cannot actually run the test suite locally currently.

@compnerd
Copy link
Member Author

compnerd commented Apr 6, 2023

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Apr 7, 2023

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Apr 7, 2023

@tomerd does that seem reasonable?

@compnerd compnerd enabled auto-merge (rebase) April 10, 2023 14:57
@compnerd compnerd merged commit 094bbb1 into swiftlang:main Apr 10, 2023
@compnerd compnerd deleted the tesseract branch April 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @tomerd @neonichu