Remove usage of temp_await from WorkspaceTests #7124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure callback methods can't block the concurrency pool Add async alternatives for Archiver Add async alternatives for AuthorizationWriter Mark non-async methods noasync to encourage migration to async Removed a cancellation test that was not actually exercising production code Co-authored-by: Max Desiatov <[email protected]>
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
reviewed
Nov 27, 2023
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all usage of temp_await with await in WorkspaceTests
Motivation:
async/await is nicer than callbacks. I want to see it more broadly adopted in SPM
Modifications:
All usages of temp_await in the WorkspaceTests target have removed. Where necessary async alternatives have been added and the completion handler methods have been marked no-async. Note: this changed is based on the currently unmerged #7102, but that PR is passing CI and I hope should see no major changes at this point
Result:
async/await adoption in
WorkspaceTests