improve handling of test output #7126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: fix cases where test output is formattet incorrectly due to exessive newline addition changes: preserve output from test hartness as-is without attempting to remove oradd newlines
|
fixes #6566 |
|
@swift-ci test |
MaxDesiatov
approved these changes
Nov 27, 2023
neonichu
approved these changes
Nov 28, 2023
|
I had a PR ready to go but you beat me to it :) |
grynspan
reviewed
Nov 28, 2023
| @@ -390,7 +390,7 @@ public struct SwiftTestTool: SwiftCommand { | |||
| let ranSuccessfully = runner.test(outputHandler: { | |||
| // command's result output goes on stdout | |||
| // ie "swift test" should output to stdout | |||
| print($0) | |||
| print($0, terminator: "") | |||
There was a problem hiding this comment.
There is another call site of test(outputHandler in the repo that needs the same fix.
|
@swift-ci test |
grynspan
approved these changes
Nov 28, 2023
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fix cases where test output is formatted incorrectly due to excessive newline addition
changes: preserve output from test hartness as-is without attempting to remove oradd newlines